提交 ac714ce0 authored 作者: hzh's avatar hzh

代码优化

上级 88daf118
...@@ -196,7 +196,10 @@ public class SysUserController extends BaseController { ...@@ -196,7 +196,10 @@ public class SysUserController extends BaseController {
@SaCheckPermission("system:user:query") @SaCheckPermission("system:user:query")
@GetMapping(value = {"/", "/{userId}"}) @GetMapping(value = {"/", "/{userId}"})
public R<SysUserInfoVo> getInfo(@PathVariable(value = "userId", required = false) Long userId) { public R<SysUserInfoVo> getInfo(@PathVariable(value = "userId", required = false) Long userId) {
SysUserBo sysUserBo = userService.selectById(userId);
if (StringUtils.equals(sysUserBo.getUserType(), UserType.SYS_USER.getUserType())) {
userService.checkUserDataScope(userId); userService.checkUserDataScope(userId);
}
SysUserInfoVo userInfoVo = new SysUserInfoVo(); SysUserInfoVo userInfoVo = new SysUserInfoVo();
SysRoleBo roleBo = new SysRoleBo(); SysRoleBo roleBo = new SysRoleBo();
roleBo.setStatus(UserConstants.ROLE_NORMAL); roleBo.setStatus(UserConstants.ROLE_NORMAL);
...@@ -249,8 +252,11 @@ public class SysUserController extends BaseController { ...@@ -249,8 +252,11 @@ public class SysUserController extends BaseController {
@PutMapping @PutMapping
public R<Void> edit(@Validated @RequestBody SysUserBo user) { public R<Void> edit(@Validated @RequestBody SysUserBo user) {
userService.checkUserAllowed(user.getUserId()); userService.checkUserAllowed(user.getUserId());
SysUserBo sysUserBo = userService.selectById(user.getUserId());
if (StringUtils.equals(sysUserBo.getUserType(), UserType.SYS_USER.getUserType())) {
userService.checkUserDataScope(user.getUserId()); userService.checkUserDataScope(user.getUserId());
deptService.checkDeptDataScope(user.getDeptId()); deptService.checkDeptDataScope(user.getDeptId());
}
if (!userService.checkUserNameUnique(user)) { if (!userService.checkUserNameUnique(user)) {
return R.fail("修改用户'" + user.getUserName() + "'失败,登录账号已存在"); return R.fail("修改用户'" + user.getUserName() + "'失败,登录账号已存在");
} else if (StringUtils.isNotEmpty(user.getPhonenumber()) && !userService.checkPhoneUnique(user)) { } else if (StringUtils.isNotEmpty(user.getPhonenumber()) && !userService.checkPhoneUnique(user)) {
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论